Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Arithmetic operations for fields which are in network order #4566

Merged
merged 25 commits into from
Apr 2, 2024
Merged

Handle Arithmetic operations for fields which are in network order #4566

merged 25 commits into from
Apr 2, 2024

Conversation

komaljai
Copy link
Contributor

Handle Arithmetic operations for fields which are in network order(annotated in header definition, action parameters and table keys)

@komaljai
Make Header fields in network order in Parser.
944edd0 
Stop conversion of header fields in deparser.
Handle network oeder and host order operations in C Program
@komaljai
Merge branch 'main' of https://github.com/komaljai/p4c into change_en…
c14a296 
…dianess
@komaljai
Update testcase output
7716732
@komaljai
Address comments and update testcases
e0da194
@komaljai
Merge branch 'main' of https://github.com/komaljai/p4c into change_en…
b5ffb3e 
…dianess
@komaljai
Address comments and update testcases
b8aa951
@komaljai
Merge branch 'main' of https://github.com/komaljai/p4c into change_en…
e93cb8e 
…dianess
@komaljai
Add comments
9b44450
@komaljai
ddressed comments
7c7608e
@komaljai
Revert change and restore annotations in parser and deparser.
f35ba2f
@komaljai
Merge branch 'main' of https://github.com/komaljai/p4c into change_en…
a9a5c5d 
…dianess
@komaljai
ndle Arithmetic operations for annotated fields in header definition,
9706c7c 
action parameters and table keys
@komaljai
Fix cpplint
271a218
@komaljai
Merge branch 'main' of https://github.com/komaljai/p4c into change_en…
bc4e5b2 
…dianess
@komaljai
Update Testcase output
49ef685
@komaljai
Merge branch 'main' of https://github.com/komaljai/p4c into change_en…
8c06a22 
…dianess
@komaljai
Fix cpplint issue
dda1ca1
@komaljai
Merge branch 'main' of https://github.com/komaljai/p4c into networkOr…
6233e26 
…der_arithmetic
@komaljai
Merge branch 'main' into networkOrder_arithmetic
e656005
@komaljai
Merge branch 'networkOrder_arithmetic' of https://github.com/komaljai…
09dc8cc 
…/p4c into networkOrder_arithmetic
komaljai
komaljai commented Mar 27, 2024
View reviewed changes
backends/ebpf/target.h Outdated Show resolved Hide resolved
@fruffy fruffy added p4tc Topics related to the P4-TC back end run-sanitizer Use this tag to run a Clang+Sanitzers CI run. labels Mar 27, 2024
maheswari-s
maheswari-s approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@maheswari-s maheswari-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

usha1830
usha1830 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@usha1830 usha1830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have a few comments/queries. Please check

testdata/p4tc_samples_outputs/checksum_parser.c Outdated Show resolved Hide resolved
backends/ebpf/codeGen.cpp Outdated Show resolved Hide resolved
backends/ebpf/codeGen.cpp Outdated Show resolved Hide resolved
@usha1830 usha1830 added this pull request to the merge queue Apr 2, 2024
Merged via the queue into p4lang:main with commit e86bac6 Apr 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbnogueira vbnogueira vbnogueira left review comments

@usha1830 usha1830 usha1830 approved these changes

@maheswari-s maheswari-s maheswari-s approved these changes

Assignees
No one assigned
Labels
p4tc Topics related to the P4-TC back end run-sanitizer Use this tag to run a Clang+Sanitzers CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@komaljai @maheswari-s @usha1830 @vbnogueira @fruffy